Skip to content

Conversation

@griffinashe
Copy link
Contributor

Adds the IBM Cloud-Native Java Expert agent to the partners collection.

Copilot AI review requested due to automatic review settings December 2, 2025 20:32
Copilot finished reviewing on behalf of griffinashe December 2, 2025 20:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the IBM Cloud Native Java Expert agent to the Partners collection. The agent is designed to help generate and review secure, resilient, and observable Java applications using Open Liberty and Kubernetes, while enforcing IBM's cloud-native development best practices.

Key Changes

  • Added new IBM Cloud Native Java Expert agent file with comprehensive Java development guidelines
  • Updated Partners collection to include the new agent (from 19 to 20 items)
  • Updated collection counts in README and documentation files

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
agents/ibm-java-agent.md New agent file defining the IBM Cloud Native Java Expert with development standards, best practices, and workflows
collections/partners.collection.yml Added ibm-java-agent.md to the Partners collection items list
collections/partners.md Added table entry for IBM Cloud Native Java Expert with installation links
docs/README.collections.md Updated Partners collection item count from 19 to 20
README.md Updated Partners collection item count from 19 to 20

Comment on lines +5 to +9
tools:
- sequencing-planning # Plan multi-step tasks; track/annotate steps
- search-reference # Search docs, standards, APIs, and code
- security-scanner # Scan dependencies, images, and supply chain artifacts
- memory-persistence # Persist verified decisions, facts, ADR links
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools list contains tool names (sequencing-planning, search-reference, security-scanner, memory-persistence) that don't appear to be valid GitHub Copilot tools. Standard GitHub Copilot agent tools include read, edit, search, shell, and MCP server tools (e.g., mcp-server-name/*). Please verify these are actual available tools or update to use standard Copilot tools. If these are conceptual tools for documentation purposes, they should be described in the agent instructions rather than listed in the tools field.

Suggested change
tools:
- sequencing-planning # Plan multi-step tasks; track/annotate steps
- search-reference # Search docs, standards, APIs, and code
- security-scanner # Scan dependencies, images, and supply chain artifacts
- memory-persistence # Persist verified decisions, facts, ADR links

Copilot uses AI. Check for mistakes.
---
name: IBM Cloud-Native Java Expert
description: An architect agent for generating and reviewing secure, resilient, and observable Java applications on Open Liberty and K8s. Enforces IBM's best practices for cloud-native development.
version: 2.0
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version field is not a standard field for agent files (.agent.md). Based on existing agents in this repository, agent files should only include fields like name, description, tools, model, and mcp-servers in their front matter. The version field should be removed.

Suggested change
version: 2.0

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,61 @@
---
name: IBM Cloud-Native Java Expert
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name field value "IBM Cloud-Native Java Expert" (with hyphen) doesn't match the title used in the Partners collection table "IBM Cloud Native Java Expert" (without hyphen). These should be consistent. Based on the table entry, update the name to "IBM Cloud Native Java Expert" (without the hyphen in "Cloud Native").

Suggested change
name: IBM Cloud-Native Java Expert
name: IBM Cloud Native Java Expert

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +10
---
name: IBM Cloud-Native Java Expert
description: An architect agent for generating and reviewing secure, resilient, and observable Java applications on Open Liberty and K8s. Enforces IBM's best practices for cloud-native development.
version: 2.0
tools:
- sequencing-planning # Plan multi-step tasks; track/annotate steps
- search-reference # Search docs, standards, APIs, and code
- security-scanner # Scan dependencies, images, and supply chain artifacts
- memory-persistence # Persist verified decisions, facts, ADR links
---
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the repository's coding guidelines for agent files, it's strongly encouraged to specify the model field to indicate which model the agent is optimized for. Consider adding a model field in the front matter, e.g., model: "claude-sonnet-4-5-20250929" or the appropriate model name.

Copilot generated this review using guidance from repository custom instructions.
@aaronpowell aaronpowell marked this pull request as draft December 2, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant